Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feather RP2040 RFM, update DVI. #7807

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

kattni
Copy link

@kattni kattni commented Mar 28, 2023

This adds the Adafruit Feather RP2040 RFM board definition. In adding it, I found a couple of issues with the Feather RP2040 DVI board files, fixed those, and reorganised pins.c further to be consistent with the RFM. We can plan to continue this organisation (if approved) for the series of upcoming Feather RP2040 with-a-specific-feature boards.

@kattni kattni requested a review from dhalbert March 28, 2023 19:25
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check against the schematics but these look good organizationally.

@dhalbert dhalbert merged commit 058499f into adafruit:main Mar 28, 2023
dhalbert pushed a commit to dhalbert/circuitpython that referenced this pull request Aug 1, 2023
The following fixes are made:
- cancelling a gather now cancels all sub-tasks of the gather (previously
  it would only cancel the first)
- if any sub-task of a gather raises an exception then the gather finishes
  (previously it would only finish if the first sub-task raised)

Fixes issues adafruit#5798, adafruit#7807, adafruit#7901.

Signed-off-by: Damien George <damien@micropython.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants