Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new boards (deneyapkart/1a/g) #7783

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Conversation

ozgurbostan
Copy link

  • Deneyap Kart
  • Deneyap Kart 1A
  • Deneyap Kart G

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - one tiny fix. Also, could you add your Creator ID and board IDS to https://github.com/creationid/creators ?

ports/espressif/boards/deneyap_kart_1a/sdkconfig Outdated Show resolved Hide resolved
@dhalbert
Copy link
Collaborator

dhalbert commented Mar 24, 2023

@ozgurbostan I tried to fix the missing newlines myself, but you didn't give permission for repo maintainers to push commits to your PR's. So we'll wait for your changes.

Add missing new line
@ozgurbostan
Copy link
Author

@ozgurbostan I tried to fix the missing newlines myself, but you didn't give permission for repo maintainers to push commits to your PR's. So we'll wait for your changes.

@dhalbert I have just fixed the missing new line.

@ozgurbostan ozgurbostan requested a review from dhalbert March 24, 2023 09:22
Add missing new line
@ozgurbostan ozgurbostan requested a review from dhalbert March 24, 2023 12:35
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience with the changes!

@dhalbert dhalbert merged commit 57ac9aa into adafruit:main Mar 24, 2023
@dhalbert
Copy link
Collaborator

Now, two more steps:

  1. PR to add your Creator ID and board IDS to https://github.com/creationid/creators
  2. PR to add these boards to https://circuitpython.org. See https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website.

@ozgurbostan
Copy link
Author

Now, two more steps:

  1. PR to add your Creator ID and board IDS to https://github.com/creationid/creators
  2. PR to add these boards to https://circuitpython.org. See https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website.

Thanks for your review and support. We have already applied for the IDs and are waiting for the process to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants