Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correcting vectorshape location property #7758

Merged
merged 1 commit into from
Mar 20, 2023
Merged

correcting vectorshape location property #7758

merged 1 commit into from
Mar 20, 2023

Conversation

jposada202020
Copy link

@jposada202020 jposada202020 commented Mar 20, 2023

PR to correct vectorshape location property

Testing Code

import vectorio
import displayio
import board

display = board.DISPLAY

palette = displayio.Palette(2)
palette.make_transparent(0)
palette[1] = 0xFFFFFF

reci = vectorio.Rectangle(pixel_shader=palette,width=10, height=50,x=100, y=100, color_index=1)

print(reci.location)
reci.location = (100, 5)
print(reci.location)

Before PR

Adafruit CircuitPython 8.0.4 on 2023-03-15; Adafruit PyPortal Titano with samd51j20
>>> import test_pr
(100, 100)
(100, 100)
>>> 

After PR

Adafruit CircuitPython 8.1.0-beta.0-35-g3ac696e7b-dirty on 2023-03-20; Adafruit PyPortal Titano with samd51j20
>>> import test_pr
(100, 100)
(100, 5)
>>> 

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit c54648c into adafruit:main Mar 20, 2023
@jposada202020 jposada202020 deleted the correcting_vector_shape_location branch March 20, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants