Diskinfo api for web workflow #7746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
previously approved these changes
Mar 20, 2023
|
Could you bump web api version from 1 to 2? That'll simplify discovery of this endpoint. |
|
latest commit increases api_version to 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7637
URL is
/cp/diskinfo.jsonResponse sizes are in bytes.Example of response:
Maybe we don't really need
block_sizein the results? I can remove it if not. I added it initially in order to test how it's looked up, which is needed to find the correct multiplier to get to bytes units.Tested successfully with Feather ESP32-S2 TFT.
Thank you to: isacben, Neradoc, and anecdata who all helped me in getting this far on implementing this API. Also Scott for the pointer to t_getfree(), the FatFs docs that were linked were quite helpful as well.