-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add port-specific modules to support matrix #7725
add port-specific modules to support matrix #7725
Conversation
When trying to test it locally, I get an error because the content is empty when trying to retrieve the previous files.json. ❯ RELEASE_TAG=8.0.0 DEBUG=1 python build_board_info.py
Not logged in
Traceback (most recent call last):
File "/Volumes/circuitpython-dev/repositories/test-pr/tools/build_board_info.py", line 268, in <module>
generate_download_info()
File "/Volumes/circuitpython-dev/repositories/test-pr/tools/build_board_info.py", line 207, in generate_download_info
git_info, current_info = get_current_info()
File "/Volumes/circuitpython-dev/repositories/test-pr/tools/build_board_info.py", line 103, in get_current_info
current_list = json.loads(base64.b64decode(response["content"]).decode("utf-8"))
File "/usr/local/Cellar/python@3.9/3.9.16/Frameworks/Python.framework/Versions/3.9/lib/python3.9/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/local/Cellar/python@3.9/3.9.16/Frameworks/Python.framework/Versions/3.9/lib/python3.9/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/Cellar/python@3.9/3.9.16/Frameworks/Python.framework/Versions/3.9/lib/python3.9/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0) I believe the reason is that the file is now above 1MB:
Calling it like this retrieves just the file, but not the associated sha: response = github.get(
"/repos/adafruit/circuitpython-org/contents/_data/files.json?ref=" + commit_sha,
headers={"Accept": "application/vnd.github.raw+json"}
) Or we can retrieve the file if the content field is empty: if response["content"] != "":
# if the file is there
current_list = json.loads(base64.b64decode(response["content"]).decode("utf-8"))
else:
# if too big, the file is not included
download_url = response["download_url"]
response = requests.get(download_url)
if not response.ok:
print(response.text)
raise RuntimeError("cannot get previous files.json")
current_list = response.json() With that, the PR does as expected. |
The problem @Neradoc observed is now happening even before this PR is merged: |
@Neradoc I tried both of the above patches to |
Here it is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also ran
docs/shared_bindings_matrix.py
throughblack
.