Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enhancements & Refactoring #7676

Merged
merged 5 commits into from
Mar 8, 2023
Merged

CI: Enhancements & Refactoring #7676

merged 5 commits into from
Mar 8, 2023

Conversation

microdev1
Copy link
Collaborator

This contains the following:

  • split boards dynamically
  • refactor workflow names
  • conditionally build all languages

@dhalbert dhalbert requested a review from tannewt March 4, 2023 17:04
tannewt
tannewt requested changes Mar 6, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these refinements. I really like the two levels of builds now. One suggestion I had will improve the job naming.

tools/build_memory_info.py Show resolved Hide resolved
tools/ci_set_matrix.py Show resolved Hide resolved
.github/workflows/re-build-boards.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/re-build-boards.yml Outdated Show resolved Hide resolved
@microdev1 microdev1 requested a review from tannewt March 6, 2023 21:53
tannewt
tannewt requested changes Mar 7, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I like the job names now.

I'd prefer to leave the file names and workflow names as-is and not add the reusable/re prefix.

@microdev1 microdev1 requested a review from tannewt March 7, 2023 19:21
tannewt
tannewt approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@tannewt tannewt merged commit 35e82a5 into adafruit:main Mar 8, 2023
@microdev1 microdev1 deleted the ci branch March 9, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
enhancement refactoring tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microdev1 @tannewt