-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: More fixes and refactoring #7631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind just splitting out every port? I split nrf out in #7497 because I needed to install nrfutil
for it. See that PR for some renaming too.
I took a look at the The port specific configuration steps/dependencies for nrf can go in: # .github/actions/deps/ports/nrf/action.yml
name: Fetch nrf port deps
runs:
using: composite
steps:
- name: Get nrfutil 7+
run: |
wget https://developer.nordicsemi.com/.pc-tools/nrfutil/x64-linux/nrfutil
chmod +x nrfutil
./nrfutil install nrf5sdk-tools
mkdir -p $HOME/.local/bin
mv nrfutil $HOME/.local/bin
echo "$HOME/.local/bin" >> $GITHUB_PATH
shell: bash
- name: Print nrfutil version
run: nrfutil -V
shell: bash Then the following conditional step can be added in: # .github/actions/deps/ports/action.yml
- name: Set up nrf port
if: steps.board-to-port.outputs.port == 'nrf'
uses: ./.github/actions/deps/ports/nrf |
It would be unfortunate to switch to this tool as we have user/developers who build on arm64 linux platforms (e.g., rpi)... |
Are you talking about |
I agree it simplifies that part but I'd still like to split the matrix by port rather than architecture. That would be clearer than having a mix as you have now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and merging. @microdev1 will follow up with rework to each port.
This PR contains the following changes:
atmel-samd
instead ofraspberrypi
: This more evenly distributes the number boards across matrix jobs..github/actions/deps/ports/...
.github.event.pull_request.head.sha
instead ofgithub.event.after
which can be empty.