Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lowest drive level for PIO #7558

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Use lowest drive level for PIO #7558

merged 1 commit into from
Feb 9, 2023

Conversation

jepler
Copy link
Member

@jepler jepler commented Feb 8, 2023

This appears to fix the scorpio problem (closes #7515) and only mildly affected a direct-drive LED example.

dhalbert
dhalbert previously approved these changes Feb 8, 2023
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix for now, and we can revisit later if we add user-configurable drive strengths.

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 8, 2023

So this would go in an 8.0.1? I think I will make a backport milestone.

@jepler jepler changed the base branch from main to 8.0.x February 9, 2023 00:20
@jepler jepler dismissed dhalbert’s stale review February 9, 2023 00:20

The base branch was changed.

@jepler
Copy link
Member Author

jepler commented Feb 9, 2023

Changed to use 8.0.x as base, as I had intended.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit fc919d2 into adafruit:8.0.x Feb 9, 2023
@dhalbert dhalbert added this to the 8.0.x milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scorpio: spurious USB resets when running demo code
2 participants