Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed empty characteristic issue with bleio+nimble. #6614

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Fixed empty characteristic issue with bleio+nimble. #6614

merged 1 commit into from
Jul 20, 2022

Conversation

litui
Copy link

@litui litui commented Jul 17, 2022

  • Based on espressif/nimble's blecent example code. Confirms that the characteristic is not empty before trying to catalogue its descriptors.
  • Running ble_gattc_disc_all_dscs on empty (no length) characteristics fails with the (not-very-informative) BLE_HS_EINVAL error if this check is not performed.

@litui
Fixed empty characteristic issue with bleio+nimble.
868a03f 
- Based on espressif/nimble's blecent example code. Confirms that the characteristic is not empty before trying to catalogue its descriptors.
- Running ble_gattc_disc_all_dscs on empty (no length) characteristics fails with the (not-very-informative) BLE_HS_EINVAL error if this check is not performed.
@litui
Copy link
Author

litui commented Jul 17, 2022

blecent usage example can be found here: https://github.com/espressif/esp-idf/blob/9b8c558e63d95b491355a22e69f247834e899b47/examples/bluetooth/nimble/blecent/main/peer.c#L192

dhalbert
dhalbert approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@dhalbert dhalbert merged commit f2bbe5a into adafruit:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litui @dhalbert