Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max3421e USB Host module not enabled for ESP32 boards #9203

Closed
todbot opened this issue Apr 25, 2024 · 0 comments · Fixed by #9207
Closed

max3421e USB Host module not enabled for ESP32 boards #9203

todbot opened this issue Apr 25, 2024 · 0 comments · Fixed by #9207
Assignees
Labels
bug espressif applies to multiple Espressif chips usb
Milestone

Comments

@todbot
Copy link

todbot commented Apr 25, 2024

CircuitPython version

Adafruit CircuitPython 9.1.0-beta.1-8-g260f3dadb3-dirty on 2024-04-24; Adafruit Feather ESP32-S2 TFT with ESP32S2

Code/REPL

import max3421e

Behavior

>>> import max3421e
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: no module named 'max3421e'

Description

This commit: aca3191 says that max3421e module is enabled for all ESP32 boards.
But https://github.com/adafruit/circuitpython/blob/main/ports/espressif/mpconfigport.mk has no CIRCUITPY_MAX3421E defined.

I can see why. When I try to define CIRCUITPY_MAX3421E in the "espressif/mpconfigport.mk" I run out of flash space ("1449568 bytes used, -7776 bytes free in flash firmware space out of 1441792 bytes (1408.0kB).")

Is there a way to fit this module in, since all ESP32 Feathers are 4MB?

Additional information

No response

@todbot todbot added the bug label Apr 25, 2024
@tannewt tannewt added usb espressif applies to multiple Espressif chips labels Apr 25, 2024
@tannewt tannewt added this to the 9.1.0 milestone Apr 25, 2024
@tannewt tannewt self-assigned this Apr 25, 2024
dhalbert pushed a commit that referenced this issue Apr 27, 2024
Enable MAX3421E support for all ESP builds.

Fixes #9203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug espressif applies to multiple Espressif chips usb
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants