Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LilyGo T-Display RP2040 #913

Merged
merged 2 commits into from
May 15, 2023

Conversation

fabaff
Copy link
Contributor

@fabaff fabaff commented Mar 26, 2022

@dhalbert
Copy link
Collaborator

Making this a draft so it's not merged before adafruit/circuitpython#6037 is done.

@makermelissa
Copy link
Collaborator

I noticed that the board_id and board filename don't match the actual board's id: lilygo_t_display_rp2040. This must be older than the additional checks we added in last year or it likely wouldn't have passed.

Copy link
Contributor

@rcarteraz rcarteraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adafruit/circuitpython#6037 has finally been merged! 🥳 A couple changes for this request and then hopefully it'll be official official!

@@ -0,0 +1,36 @@
---
layout: download
board_id: "lilygo_t_dispaly_rp2040"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

board_id: "lilygo_t_display_rp2040"

title: "T-Display RP2040 Download"
name: "T-Display RP2040"
manufacturer: "LILYGO"
board_url: "http://www.lilygo.cn/pro.aspx?FId=n3:3:3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manufacturer: "LILYGO"
board_url: "http://www.lilygo.cn/pro.aspx?FId=n3:3:3"
board_image: "lilygo_t_display_rp2040.jpg"
date_added: 2022-4-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-5-15

@makermelissa makermelissa marked this pull request as ready for review May 15, 2023 22:06
@makermelissa
Copy link
Collaborator

I pushed the requested updates by @rcarteraz as this is pretty stale. I also fixed some other spelling issues.

makermelissa
makermelissa previously approved these changes May 15, 2023
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the fixes I pushed.

@rcarteraz
Copy link
Contributor

Looks good with the fixes I pushed.

Thank you! 🥳

@makermelissa
Copy link
Collaborator

Wait no. Apparently it includes a year's worth of fixes. Need to rebase...

@makermelissa
Copy link
Collaborator

Rebase successful.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now it looks good.

@makermelissa makermelissa merged commit 5e96b38 into adafruit:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants