-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LilyGo T-Display RP2040 #913
Conversation
Making this a draft so it's not merged before adafruit/circuitpython#6037 is done. |
I noticed that the board_id and board filename don't match the actual board's id: lilygo_t_display_rp2040. This must be older than the additional checks we added in last year or it likely wouldn't have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adafruit/circuitpython#6037 has finally been merged! 🥳 A couple changes for this request and then hopefully it'll be official official!
_board/lilygo-t-display_rp2040.md
Outdated
@@ -0,0 +1,36 @@ | |||
--- | |||
layout: download | |||
board_id: "lilygo_t_dispaly_rp2040" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
board_id: "lilygo_t_display_rp2040"
_board/lilygo-t-display_rp2040.md
Outdated
title: "T-Display RP2040 Download" | ||
name: "T-Display RP2040" | ||
manufacturer: "LILYGO" | ||
board_url: "http://www.lilygo.cn/pro.aspx?FId=n3:3:3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_board/lilygo-t-display_rp2040.md
Outdated
manufacturer: "LILYGO" | ||
board_url: "http://www.lilygo.cn/pro.aspx?FId=n3:3:3" | ||
board_image: "lilygo_t_display_rp2040.jpg" | ||
date_added: 2022-4-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2023-5-15
I pushed the requested updates by @rcarteraz as this is pretty stale. I also fixed some other spelling issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with the fixes I pushed.
Thank you! 🥳 |
Wait no. Apparently it includes a year's worth of fixes. Need to rebase... |
390117d
to
a36b904
Compare
Rebase successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now it looks good.
Depends on adafruit/circuitpython#6037