Don't add untracked files in an adabot bundle update #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we changed adabot to experimentally build the bundle before pushing it.
This is great, as it will hopefully avoid pushing broken bundles, which cause more problems down the line compared to just not having an updated bundle.
However, this change caused circuitpython-build-tools to create a path "build_deps" with some files inside it, and adabot added those files. (adafruit/Adafruit_CircuitPython_Bundle@91e3ce1)
Since an adabot bundle update should only ever change tracked files, change how git is invoked so that it does not add untracked files.