-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for the Makerdiary nRF52840 Connect Kit board #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks and please update PR according to review. Once done, please also add your board to the ci list as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml
changes requested to board-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the changes, ok, i must await makerdiary response?
thanks, it looks good, though you need to add this board to the ci yml as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml |
Sure |
please push the ci yml changes as part of this pr |
@hathach |
anything else need to be fixed ? |
vid, pid confirmation |
OK, will follow up my request i sent to makerdiary |
Response from Makerdiary Our partner SeeedStudio has assigned us 2886:F001~2886:F00F, and we give nRF52840-Connect-Kit UF2 Bootloader the 2886:F00F. |
I have updated board.h with the confirmed VID:PID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all is good
This PR adds support for the Makerdiary nRF52840 Connect Kit board.
Matches the format of the existing Makerdiary Pitaya Go board
https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/src/boards/pitaya_go/board.h