-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The detect_w5500 and detect_w5100s functions reset the Wiznet SOC #81
Conversation
…_w5500, detect_w5100s to _detect_and_reset_w5100s.
Shouldn't user code have a way to detect which hardware is present (I would want it). If not this, then a separate API?? |
Good point. After initializing the hardware, |
Actually, that exists as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working on W5100S and W5500.
Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPxl8 to 0.2.0 from 0.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPxl8#4 from adafruit/enhancements Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.18 from 1.12.17: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#81 from BiffoBear/detect_5500_error Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#22 from paul-1/my-main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Closes #67 These functions shouldn't be called by the user. They are only used by
__init__
to check which hardware is present. Renamed the functions and refactored them inside_w5xxx_init
(itself renamed). This prevents them from being called by the user.