Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TFT-in-use-error #49

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Fix TFT-in-use-error #49

merged 1 commit into from
Jul 29, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Jul 29, 2019

Fixes #48 on 4.1.0 RC1. Reverts to the try/except modified by #45

Works with no errors (incl. importerrors) when combined with #47

@brentru brentru requested review from jerryneedell and a team July 29, 2019 15:24
jerryneedell
jerryneedell approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I was not sure of the history for this and if this was what was still wanted for the PyPortal, but since it worked before it should be OK now ;-)

@brentru brentru merged commit cf6c110 into adafruit:master Jul 29, 2019
@brentru brentru deleted the fix-tft-in-use branch July 29, 2019 15:29
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 29, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@fc4488a)
0200a19 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.7.0 from 1.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#61 from brentru/switch-requests
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#59 from mscosti/server

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.2 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#50 from brentru/switch-requests
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#49 from brentru/fix-tft-in-use
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#47 from jerryneedell/jerryn_fixcursor
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#42 from adafruit/ladyada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyportal_simpletest - TFT in use
2 participants
@brentru @jerryneedell