Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to pass ESP and SPI objects. #33

Merged
merged 4 commits into from
May 10, 2019

Conversation

ChewyTurtle
Copy link

I needed the ability to use the wifi connection before calling adafruit_pyportal.py to do required Application authorization for Twitter's API. Their API requires an access token from a POST request which I get so I can send adafruit_pyportal.py the GET url with the correct access token in the headers.

I'm here with you guys at pycon if that helps.

…calling pyportal to do required qpplication authorization for twitters API
@ladyada
Copy link
Member

ladyada commented May 8, 2019 via email

@ChewyTurtle
Copy link
Author

I tried to fix the version. I hope I did it right.

@ladyada
Copy link
Member

ladyada commented May 8, 2019

do you ever use spi? i think you just need to pass in the esp!

@ChewyTurtle
Copy link
Author

Yeah, at least I think so. I used spi to define esp before calling the pyportal object. I tried doing it without passing spi but the script failed when it tried to look for the SD card.

@ladyada
Copy link
Member

ladyada commented May 9, 2019

oh right yah its used for SD access

@ladyada ladyada requested a review from brentru May 9, 2019 01:41
@brentru
Copy link
Member

brentru commented May 9, 2019

@ChewyTurtle Heya, the build is failing, see the travis log for details - let me know if you have any Q's: https://travis-ci.com/adafruit/Adafruit_CircuitPython_PyPortal/builds/111126972#L293

@ChewyTurtle
Copy link
Author

@brentru I think I fixed the issues from the build failing. I haven't seen that format before but it looked like it was mostly spacing issues. I removed the extra white space and fixed the indentation level. Hopefully that is what was needed. Let me know if it's something else!

adafruit_pyportal.py Outdated Show resolved Hide resolved
adafruit_pyportal.py Outdated Show resolved Hide resolved
adafruit_pyportal.py Outdated Show resolved Hide resolved
adafruit_pyportal.py Outdated Show resolved Hide resolved
adafruit_pyportal.py Outdated Show resolved Hide resolved
…ional param comments for the two variables added to the init
@brentru
Copy link
Member

brentru commented May 10, 2019

Looks good, merging in!

@brentru brentru merged commit b94fcde into adafruit:master May 10, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 10, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.0.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#28 from caternuson/iss26_continuous
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#31 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#14 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 3.0.6 from 3.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#27 from peterhinch/mode-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#25 from peterhinch/issues_23_24

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.3.2 from 3.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#23 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.3.5 from 4.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#50 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#19 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#9 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#5 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.0.2 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#18 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#33 from ChewyTurtle/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#5 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.6.3 from 2.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#25 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#8 from dherrada/master
@ChewyTurtle
Copy link
Author

ChewyTurtle commented May 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants