Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issues and add license so CI builds. #2

Merged
merged 4 commits into from
Jun 30, 2024

Conversation

kbsriram
Copy link
Contributor

No description provided.

@kbsriram kbsriram closed this Mar 30, 2024
@adafruit adafruit deleted a comment from kbsriram Mar 30, 2024
@dhalbert
Copy link

BTW, did you mean to close this? Maybe it was meant for your own repo?

@jepler
Copy link
Member

jepler commented Mar 31, 2024

The CI error says:

Warning, treated as error:
autodoc: failed to import module 'adafruit_pio_uart'; the following exception was raised:
No module named 'rp2pio'

The first fix to try for this kind of error building documentation is to edit docs/conf.pyand add the module(s) that could not be imported to the list of "autodoc_mock_imports". In this case, rp2pio. This will allow the documentation building process to pretend rp2pio is importable, but occasionally leads to further errors.

An example of this is: https://github.com/adafruit/Adafruit_CircuitPython_NeoPxl8/blob/main/docs/conf.py#L30

@kbsriram
Copy link
Contributor Author

Thank you @dhalbert and @jepler ! I'd closed this thinking I'd do some research on the CI issue first, without adding review load on you folks. Thank you for the very helpful hints - I'll re-open and see if I can get a clean build :-)

@kbsriram kbsriram reopened this Mar 31, 2024
@kbsriram kbsriram marked this pull request as draft March 31, 2024 22:09
@kbsriram kbsriram marked this pull request as ready for review March 31, 2024 22:22
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much knowledge of PIO specifically, but I had a look through these changes.

The fixes to lint and other pre-commit checks all look good to me at this point, and the behavior of the looks unchanged to me.

Thanks for working on this @kbsriram

@FoamyGuy FoamyGuy merged commit 07ca619 into adafruit:main Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants