Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop the reconnect infinite loop #29

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Stop the reconnect infinite loop #29

merged 2 commits into from
Apr 21, 2020

Conversation

jimbobbennett
Copy link
Contributor

Fix for #28

@brentru
Copy link
Member

brentru commented Apr 17, 2020

@jimbobbennett Which hardware did you test this on? Thanks!

@brentru brentru self-requested a review April 17, 2020 22:03
@jimbobbennett jimbobbennett marked this pull request as draft April 17, 2020 22:04
@jimbobbennett jimbobbennett marked this pull request as ready for review April 17, 2020 22:04
@jimbobbennett
Copy link
Contributor Author

@brentru - a PyBadge with an Airlift FeatherWing. It's my only test board at the moment as a friend has my PyPortal and I can't get to her to get it back till the lockdown lifts...

brentru
brentru approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug, looks good to go. Tested on PyPortal.

@brentru brentru merged commit 2c7f3c3 into adafruit:master Apr 21, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 22, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@ddcf3f0)
228efef 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.3.2 from 3.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#89 from anecdata/gpio

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 2.2.0 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#29 from jimbobbennett/master
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#30 from jimbobbennett/fix_broker
rtwfroody pushed a commit to rtwfroody/Adafruit_CircuitPython_MiniMQTT that referenced this pull request Sep 18, 2022
@brentru
Merge pull request adafruit#29 from jimbobbennett/master
195bfc0 
Stop the reconnect infinite loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimbobbennett @brentru