Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_recv_into() is not used anymore #155

Merged
merged 1 commit into from
Feb 22, 2023
Merged

_recv_into() is not used anymore #155

merged 1 commit into from
Feb 22, 2023

Conversation

vladak
Copy link
Contributor

@vladak vladak commented Feb 16, 2023

This change removes _recv_into(). It was initially introduced in 8492a58, then actually used in 2ae61a4 and then the call was removed in ea96633.

@tekktrik tekktrik requested a review from a team February 17, 2023 14:55
FoamyGuy
FoamyGuy approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @vladak.

I checked 'find usages' in pycharm to confirm this was unused and indeed it comes up empty. I also verified aio example script still working as intended with Feather ESP32-S2 TFT

@FoamyGuy FoamyGuy merged commit 988332f into adafruit:main Feb 22, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 22, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@2415fa6)
b81fcf4 
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.6.3 from 4.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#113 from adafruit/matrix_fill_color_swap

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.3.0 from 7.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#155 from vladak/recv_into_cleanup
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#145 from vladak/tls_port_detection

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladak @FoamyGuy