Fix log files not containing any newlines ever #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Thank you for the fix @aggieNick02! I tested this successfully on a Pyportal Titano using slightly modified version of the filehandler example from this repo.
The currently released version does not include newlines for the "regular" logger functions like debug(), info(), error() etc.. There are some newlines when you use logger.exception(e) but only the ones that come from the exception itself, the first line of the exception is not preceded by a newline so it ends up at the end of a long line of everything that came before it.
In the version from this PR the "regular" functions do correctly get newlines for each message and the exception() output still contains it's relevant newlines also.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 3, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_PM25 to 2.1.17 from 2.1.16: > Merge pull request adafruit/Adafruit_CircuitPython_PM25#28 from snkYmkrct/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD4X to 1.4.4 from 1.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_SCD4X#23 from snkYmkrct/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT4x to 1.0.20 from 1.0.19: > Merge pull request adafruit/Adafruit_CircuitPython_SHT4x#15 from snkYmkrct/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.2.3 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#26 from adafruit/redundant-constructor Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 5.5.1 from 5.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#65 from PCPartPicker/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #64