Add support for multiline logs and exceptions #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 24, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 5.4.0 from 5.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#60 from furbrain/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPDX-FileCopyrightText: 2021 Adafruit Industries
SPDX-License-Identifier: MIT
This PR adds the exception method to the logging module. This can be
of use for detecting and recording unexpected bugs in log running
processes.
As the exception report includes newlines, I've made newline handling
more robust in StreamHandler.format - it splits all input lines into a
list (which is robust to different newline formats), and then uses
terminator to separate the lines - so changing the separator now
just means changing the value of terminator. FileHandler.format is now
redundant, as we just need to specify the terminator as "\r\n"
I have tested both StreamHandler and FileHandler on a Pico W and they work
as expected