Customcolorschase #51

cjsieh · 2020-06-15T16:36:21Z

Allow for a list of colors to be used with the Chase animation. New animation CustomColorsChase is provided with example. Issue#50 .

Add ability to select custom colors for chase animation

Added CustomColorChase example. Updated All example with new CustomColorChase

Changed from customcolorchase to customcolorschase

Changed example CustomColorChase to CustomColorsChase

Change from CustomColorChase to CustomColorsChase

changed from customcolorchase to customcolorschase

fixed spaces before/after parameters

reformatted via black

fixed "line too long" as indicated by pylint

kattni · 2020-06-18T22:07:23Z

I am working on reviewing your code. The current Pylint failure is not in your code. I am submitting a PR with the fix.

FoamyGuy

I tested these successfully with a Neopixel Featherwing, and with a 30 pixel strip. Really neat animation, thank you for adding it @cjsieh!

kattni

Hello, @cjsieh! Thanks so much for contributing this animation. I've tested it and it works successfully. There are a few changes I'd like to see before we merge it. Please see the suggestions below. Note: I committed a fix to a separate file that was causing Pylint to fail on a file you had not edited. The new Pylint failure is addressed in the comments below. Make sure you update your local version sequence.py to match the new version in the PR.

With the new example, I think it would be better to choose some other nice color combinations and include them without themed names.

Let me know if you need any assistance with any of the changes. I'm happy to help!

kattni · 2020-06-17T21:25:58Z

adafruit_led_animation/animation/customcolorschase.py

+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+"""
+`adafruit_led_animation.animation.rainbowchase`


This needs to be updated to match the module name, e.g. adafruit_led_animation.animation.customcolorchase.

kattni · 2020-06-17T21:26:14Z

adafruit_led_animation/animation/customcolorschase.py

+`adafruit_led_animation.animation.rainbowchase`
+================================================================================
+
+Rainbow chase animation for CircuitPython helper library for LED animations.


This needs to be updated to describe the module, e.g. Custom color chase animation for CircuitPython helper library for LED animations..

kattni · 2020-06-17T21:26:49Z

adafruit_led_animation/animation/customcolorschase.py

+from adafruit_led_animation.color import RAINBOW
+
+
+class CustomColorsChase(Chase):


Class names are typically singular. Please update this to CustomColorChase. This will also require updating all subsequent use of the class name.

kattni · 2020-06-17T21:41:06Z

examples/led_animation_customcolorschase.py

+# Patriotic
+custom_colors_chase_rwb = CustomColorsChase(
+    pixels, speed=0.1, colors=[RED, WHITE, BLUE], size=2, spacing=3
+)


We have a worldwide community and want everyone to feel welcome and included. Including this color combination under this name limits the scope of the example to the US, and could create a situation where users from elsewhere in the world, or even in the US, feel excluded. In light of the current climate, I feel it should be removed altogether.

kattni · 2020-06-17T21:45:27Z

examples/led_animation_customcolorschase.py

+custom_colors_chase_rwb = CustomColorsChase(
+    pixels, speed=0.1, colors=[RED, WHITE, BLUE], size=2, spacing=3
+)
+# St Pat Day


Associating these color combinations with holidays could be exclusionary as some do not celebrate them. The colors are fine, but please remove the holiday themed comments.

kattni · 2020-06-17T21:47:36Z

examples/led_animation_customcolorschase.py

+)
+
+# colors default to RAINBOW
+custom_colors_chase_rainbow = CustomColorsChase(pixels, speed=0.1, size=2, spacing=3)


I would update this to custom_color_chase_rainbow - removing the s from colors to match the class rename. Same suggestion goes for all instances of custom_colors in this example.

kattni · 2020-06-18T19:09:34Z

examples/led_animation_all_animations.py

@@ -43,6 +44,9 @@
 rainbow_comet = RainbowComet(pixels, speed=0.1, tail_length=7, bounce=True)
 rainbow_chase = RainbowChase(pixels, speed=0.1, size=3, spacing=2, step=8)
 rainbow_sparkle = RainbowSparkle(pixels, speed=0.1, num_sparkles=15)
+custom_colors_chase = CustomColorsChase(


Call this custom_color_chase to match the class rename. (As well, the class name will need to be updated.)

kattni · 2020-06-18T19:09:51Z

examples/led_animation_all_animations.py

@@ -57,6 +61,7 @@
    rainbow_comet,
    sparkle_pulse,
    rainbow_chase,
+    custom_colors_chase,


Update this to match, e.g. custom_color_chase.

kattni · 2020-06-18T21:44:55Z

examples/led_animation_customcolorschase.py

@@ -0,0 +1,61 @@
+"""
+This example displays the basic animations in sequence, at a five second interval.


This comment needs to be updated to describe the new example.

kattni · 2020-06-18T21:46:03Z

examples/led_animation_customcolorschase.py

+
+from adafruit_led_animation.animation.customcolorschase import CustomColorsChase
+from adafruit_led_animation.sequence import AnimationSequence
+from adafruit_led_animation.color import PINK, PURPLE, GREEN, RED, WHITE, BLUE


PURPLE is not used. If you do not intend to use it, please remove it from the imports.

remove references to rainbowchase. Change customcolorschase to customcolorchase.

put in wrong place

Changed references to rainbowchase. Changed from CustomColorsChase to CustomColorChase

changed from customcolorschase to customcolorchase

change from CustomColorsChase to CustomColorChase

changed from ccustomcolorschase to customcolorchase

prefixed "black" formating

fixed description removed reference to advance_on_cycle_complete as not used now

kattni

Thank you for the updates!

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#45 from jerryneedell/jerryn_size Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.3.1 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#51 from cjsieh/customcolorchase > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#52 from kattni/sequence-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 3.1.1 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#41 from brentru/example-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#11 from theelectricmayhem/patch-1

cjsieh added 7 commits June 14, 2020 18:50

Add files via upload

33a95d6

Add ability to select custom colors for chase animation

Add files via upload

ca806b8

Added CustomColorChase example. Updated All example with new CustomColorChase

Add files via upload

a6ff874

Changed from customcolorchase to customcolorschase

Delete led_animation_customcolorchase.py

9d41651

Changed from customcolorchase to customcolorschase

Add files via upload

4e7ffc1

Changed example CustomColorChase to CustomColorsChase

Add files via upload

85edc47

Change from CustomColorChase to CustomColorsChase

Delete customcolorchase.py

e62e517

changed from customcolorchase to customcolorschase

ladyada requested a review from kattni June 15, 2020 16:57

Add files via upload

b068b7c

fixed spaces before/after parameters

cjsieh mentioned this pull request Jun 15, 2020

Like to use Custom Colors with "chase" #50

Closed

cjsieh added 3 commits June 15, 2020 13:37

Add files via upload

5892c25

reformatted via black

Add files via upload

3a224b0

reformatted via black

Add files via upload

05c6908

fixed "line too long" as indicated by pylint

FoamyGuy approved these changes Jun 19, 2020

View reviewed changes

Add sequence fix.

4d8971d

kattni suggested changes Jun 19, 2020

View reviewed changes

cjsieh added 8 commits June 19, 2020 21:22

Add files via upload

c88584d

remove references to rainbowchase. Change customcolorschase to customcolorchase.

Delete customcolorchase.py

5554e36

put in wrong place

Add files via upload

201bb47

Changed references to rainbowchase. Changed from CustomColorsChase to CustomColorChase

Delete customcolorschase.py

ef4435c

changed from customcolorschase to customcolorchase

Add files via upload

9d2b206

change from CustomColorsChase to CustomColorChase

Delete led_animation_customcolorschase.py

1d0b9da

changed from ccustomcolorschase to customcolorchase

Add files via upload

1a600cf

prefixed "black" formating

Add files via upload

a8ad8eb

fixed description removed reference to advance_on_cycle_complete as not used now

kattni approved these changes Jun 22, 2020

View reviewed changes

kattni merged commit 3dbe521 into adafruit:master Jun 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Customcolorschase #51

Customcolorschase #51

cjsieh commented Jun 15, 2020

kattni commented Jun 18, 2020

FoamyGuy left a comment

kattni left a comment

kattni Jun 17, 2020

cjsieh Jun 20, 2020

kattni Jun 17, 2020

cjsieh Jun 20, 2020

kattni Jun 17, 2020

cjsieh Jun 20, 2020

kattni Jun 17, 2020

cjsieh Jun 20, 2020

kattni Jun 17, 2020

cjsieh Jun 20, 2020

kattni Jun 17, 2020

kattni Jun 18, 2020

cjsieh Jun 20, 2020

kattni Jun 18, 2020

cjsieh Jun 20, 2020

kattni Jun 18, 2020

cjsieh Jun 20, 2020

kattni Jun 18, 2020

cjsieh Jun 20, 2020

kattni left a comment

		from adafruit_led_animation.color import RAINBOW


		class CustomColorsChase(Chase):

		@@ -0,0 +1,61 @@
		"""
		This example displays the basic animations in sequence, at a five second interval.

Customcolorschase #51

Customcolorschase #51

Conversation

cjsieh commented Jun 15, 2020

kattni commented Jun 18, 2020

FoamyGuy left a comment

Choose a reason for hiding this comment

kattni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kattni left a comment

Choose a reason for hiding this comment