Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9x compatibility #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

9x compatibility #32

wants to merge 2 commits into from

Conversation

FoamyGuy
Copy link
Contributor

updating main library to be 9x compatible

tannewt
tannewt requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I want to add a bunch of code like this everywhere just to avoid the warning messages. Instead, we could wait until we no longer support 8 to move everything over to the new modules directly. We could disable the warning messages until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FoamyGuy @tannewt