Removed Shared i2C bus from a bunch of FeatherWings #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deshipu
approved these changes
Mar 15, 2019
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 15, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.2.2 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#35 from adafruit/tannewt-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#15 from jerryneedell/jerryn_fix_tilegrid Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#6 from jerryneedell/jerryn_fix_tilegrid Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.7.3 from 1.7.2: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#36 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.4.1 from 1.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#24 from siddacious/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to just use the onboard I2C or be able to pass a defined I2C into multiple FeatherWing libraries, I have removed the Shared I2C file. An additional parameter was added that defaults to using the onboard I2C if it's not specified. I tested this on the 7-Segment, AlphaNumeric, 16x8 Matrix and RTC FeatherWings. I don't have the Joystick or INA219 FeatherWings at the moment, so those are untested. However, based on my testing results of the other four and that the code is basically the same, it should work without a hitch. This PR is to address #35.