Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed travis.yml, busdevice #10

Merged
merged 16 commits into from
Aug 9, 2018
Merged

Fixed travis.yml, busdevice #10

merged 16 commits into from
Aug 9, 2018

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Aug 2, 2018

No description provided.

@kattni kattni requested a review from brennen August 2, 2018 23:33
@kattni
Copy link
Contributor Author

kattni commented Aug 3, 2018

Need to add dependency PCA9685.

@kattni
Copy link
Contributor Author

kattni commented Aug 3, 2018

Also needs INA219. On hold until those are setup.

@kattni
Copy link
Contributor Author

kattni commented Aug 4, 2018 •
edited
Loading

Dependencies added, failing on Sphinx now. Adafruit-Blinka should be handling the failure, I'm not entirely sure why it's not. Could be that it's using a shared I2C setup. It's possible we could skip this one, but I would hook a FeatherWing up to a RPi, so I assume other people will as well, and these helper libs are great. They'll eventually be expanded to include more wings as well. So it might be worth figuring out why it's not working.

sommersoft
sommersoft reviewed Aug 8, 2018
View reviewed changes
docs/conf.py Outdated

intersphinx_mapping = {
'python': ('https://docs.python.org/3.4', None),
'BusDevice': ('https://circuitpython.readthedocs.io/projects/bus_device/en/latest/', None),
'Register': ('https://circuitpython.readthedocs.io/projects/register/en/latest/', None),
'CircuitPython': ('https://circuitpython.readthedocs.io/en/latest/', None),
'motor': ('https://circuitpython.readthedocs.io/projects/motor/en/latest/', None)}
'motor': ('https://circuitpython.readthedocs.io/projects/motor/en/latest/', None),
'seesae': ('https://circuitpython.readthedocs.io/projects/seesaw/en/latest/', None),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo...'seesaw`: (don't think this is related to Travis failure)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this and had already fixed it, hadn't pushed yet.

@kattni
Copy link
Contributor Author

kattni commented Aug 9, 2018

I'm not convinced this won't break the docs. It looks weird building locally, but it always looks weird building locally so I can't tell whether it's a local issue or whether it'll carry to RTD. Giving api.rst a title means the modules don't show up on the left column. You'd have to click the title to get to the page with the modules. Locally, the modules don't show up on the api.rst page, instead it says Used by autodoc_mock_imports three times. There is a chance that this will also cause that failure to occur on RTD.

I guess we merge it and see what happens.

@brennen brennen merged commit 1ae2d2f into adafruit:master Aug 9, 2018
@kattni kattni mentioned this pull request Aug 9, 2018
Merged
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 10, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e893f58)
881d245 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#5 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.2.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#4 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 0.9.2 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#15 from kattni/api-doc-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#14 from kattni/busdevice-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#13 from adafruit/revert-8-pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#12 from adafruit/revert-9-pypi-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#11 from adafruit/revert-10-pypi-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#10 from kattni/pypi-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#9 from kattni/pypi-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.2.0 from 3.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#26 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.2.0 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#9 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#31 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#30 from apatt/master
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#28 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.2.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#4 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#3 from sommersoft/new_docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sommersoft sommersoft sommersoft left review comments

@brennen brennen Awaiting requested review from brennen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kattni @sommersoft @brennen