Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.connect(): Auto-select UDP_MODE #201

Merged
merged 2 commits into from
May 6, 2024
Merged

socket.connect(): Auto-select UDP_MODE #201

merged 2 commits into from
May 6, 2024

Conversation

jepler
Copy link
Member

@jepler jepler commented May 6, 2024

This improves compatibility with the standard socket module

Not tested. Prompted by adafruit/Adafruit_CircuitPython_NTP#32

jepler added 2 commits May 5, 2024 20:39
This improves compatibility with the standard socket module
@justmobilize
Copy link
Collaborator

@jepler this makes sense to me

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented May 6, 2024

Does this need to come along with some other change inside adafruit_connection_manager or elsewhere? I tried this branch on a PyPortal Titano with the currently released connection manager and the esp32spi_simpletest.py from requests library but I seem to consistently get this exception raised:

Traceback (most recent call last):
  File "code.py", line 46, in <module>
  File "adafruit_connection_manager.py", line 124, in get_radio_socketpool
ImportError: no module named 'adafruit_esp32spi.adafruit_esp32spi_socket'

Maybe this is related to #198

@FoamyGuy
Copy link
Contributor

FoamyGuy commented May 6, 2024

Does this need to come along with some other change...

I understand now. adafruit_connection_manager is frozen into the builds it appears. And the current release of ESP32SPI is not compatible with the version of adafruit_connection_manager that is frozen in to the current stable release (haven't tried newest).

With the current connection manager pasted into the root of CIRCUITPY to override the frozen instance, I was able to test this successfully as well with that simpletest script.

As an aside, it might be nice if circup were aware of the list of frozen modules per device so that it could give you a warning if / when you install a library that is not going to have any effect by default due to being overridden by a frozen one.

@FoamyGuy FoamyGuy merged commit 56864ac into main May 6, 2024
2 checks passed
@justmobilize
Copy link
Collaborator

@FoamyGuy I had asked at one point about frozen libs, and since the amount of devices were low, it was said it wasn't worth it.

Also, it will install things in lib that are frozen, and then they don't get used... I had thought of adding a method to install in root to fix this as well.

Happy to take this in if wanted

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 7, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.1.1 from 8.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#201 from adafruit/connect_dgram_mode

Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.5.0 from 1.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#38 from RetiredWizard/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.2.0 from 1.1.27:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#26 from ContosChaos/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.5.1 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#34 from RossK1/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants