Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big refactor to match arduino logic separation #9

Merged
merged 30 commits into from
Mar 31, 2019
Merged

Big refactor to match arduino logic separation #9

merged 30 commits into from
Mar 31, 2019

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Mar 31, 2019

this also made it possible to add more displays, now has 2.7" tricolor support!

@ladyada
get rid of clear_display/clear_buffer and replace with just fill()
bdda668
@ladyada
charge arg order/kwarg, make busy/reset optional
9c51956
@ladyada
fix bitmap example, tested!
fb19eea
@ladyada
new format
c4002d0
@ladyada
use mem buffer if no SRAM pin
346a9d4
@ladyada
begin framebuffification
f7c3501
@ladyada
add const underscores and rotation
4f9b90c
@ladyada
fix none-8-bit boundary sizes
0728206
@ladyada
ahh, orientation is always with inkdots at bottom
cf49a1d
@ladyada
width/height change with rotation
642cb0d
@ladyada
fix incorrect init order
2c20e84
@ladyada
big refactor but now works with ram or sram
7fd35d0
@ladyada
fix width and height
b32893c
@ladyada
linty!@
fe0cb4d
@ladyada
fix pylint spi.write complaint
ad5b467
@ladyada
lint examples
d908c69
@ladyada
so close!
cf64f48
@ladyada
lintylint
42de3be
@ladyada
add 2.7" tricolor and single byte transfer support for weird chips
e695787
@ladyada
linting
9010050
@ladyada
add line for 2.7" and also more complete framebuf test
0921380
@deshipu
Copy link

deshipu commented Mar 31, 2019

Tested with the https://www.adafruit.com/product/3625 and a Feather M0 Basic on the CP4.0beta6 with the simpletest:
IMG_20190331_224516

@anecdata
Copy link
Member

anecdata commented Mar 31, 2019 •
edited
Loading

Tested successfully with Feather M4 & FeatherWing EPD on the CP4.0beta6 with simpletest modified:
D9 & D10 are swapped, and srcs = None, rst = None, and busy = None
and with updated (yesterday) framebuf from ladyada/Adafruit_CircuitPython_framebuf
Screen Shot 2019-03-31 at 5 52 44 PM

makermelissa
makermelissa suggested changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs some minor linting, otherwise it tested good.

@ladyada
Copy link
Member Author

ladyada commented Mar 31, 2019

yah almost done!

makermelissa
makermelissa approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@makermelissa makermelissa merged commit c974cec into adafruit:master Mar 31, 2019
@makermelissa
Copy link
Contributor

Want me to bump?

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 1, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@52a9ec7)
387b63f 
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.0.0 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#9 from ladyada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#16 from ladyada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_DymoScale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ladyada @deshipu @anecdata @makermelissa