New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NoneType check for glyph height #51

Merged

tannewt merged 1 commit into adafruit:master from caternuson:iss50

Jun 18, 2020

Contributor

caternuson commented Jun 18, 2020

For #50. Adds a simple check to make sure the glyph is not a NoneType.

Adafruit CircuitPython 5.3.0 on 2020-04-29; Adafruit Circuit Playground Bluefruit with nRF52840
>>> from adafruit_bitmap_font import bitmap_font
>>> from adafruit_display_text import label
>>> font = bitmap_font.load_font("/monoMMM_5_90.bdf")
>>> my_label = label.Label(font, text="hello", color=0xFFFFFF)
>>>


          add glyph check

d9f759e

caternuson requested a review from a team

June 18, 2020 17:33

tannewt approved these changes

View reviewed changes

Member

tannewt commented Jun 18, 2020

Thank you!

tannewt merged commit cb5e370 into adafruit:master

caternuson mentioned this pull request

Will fail if font does not have expected glyphs #50

Closed

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@b025932)

d18a50c

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.2.0 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#26 from FoamyGuy/rotation_modifier

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#10 from kattni/combo-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.0.0 from 6.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#89 from dhalbert/easier-prefixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.10.0 from 0.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#10 from dhalbert/match_prefixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.3.0 from 0.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#12 from dhalbert/match_prefixes
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#10 from adafruit/add-build-yml

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.1.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#4 from dhalbert/match-prefix

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Eddystone to 0.10.0 from 0.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Eddystone#8 from dhalbert/match_prefixes
  > build.yml: add black formatting check

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.7.1 from 2.7.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#51 from caternuson/iss50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet