Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO_HTTP: Support creating group data with send_group_data #124

Merged
merged 12 commits into from
Jul 18, 2024
Merged

IO_HTTP: Support creating group data with send_group_data #124

merged 12 commits into from
Jul 18, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Jul 16, 2024

Fixes #97

@brentru as mentioned in discord, I had a quick look at this while in the codebase, and this seemed reasonable. I also fixed the path for send_batch_data. That then lead me to poke my nose in and test batch method (requiring from collection import namedtuples), I'll leave that for now

@github-actions GitHub Actions
Copy link

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

@tyeth
Copy link
Contributor Author

tyeth commented Jul 16, 2024

Just a note that it occurred to me to test the created_at field from device (failed due to RTC not set) so I moved to using io.receive_time(), which I then thought to test from another country with crazier time zone offset (NZ) which failed.

I've therefore added an optional timezone argument to the receive_time method and updated the demo to use it. Tested tz argument to integration with GB and UTC, blank string didn't work (therefore we only add the tz argument if necessary)

@tyeth tyeth marked this pull request as ready for review July 16, 2024 18:37
@tyeth tyeth requested a review from brentru July 16, 2024 18:38
@tyeth tyeth mentioned this pull request Jul 16, 2024
Open
brentru
brentru approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@brentru brentru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tyeth tyeth merged commit 2787332 into main Jul 18, 2024
2 checks passed
@tyeth tyeth deleted the tyeth/issue97 branch July 18, 2024 10:25
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 20, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d723e94)
1dfbd80 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.9.0 from 5.8.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#125 from adafruit/update_batch_send_to_take_dict
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#124 from adafruit/tyeth/issue97
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#123 from adafruit/tyeth/issue122

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IO_HTTP: Support creating group data
2 participants
@tyeth @brentru