Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove imp module usage #48

Merged
merged 1 commit into from
Jan 22, 2025
Merged

remove imp module usage #48

merged 1 commit into from
Jan 22, 2025

Conversation

FoamyGuy
Copy link

@ladyada
Resolves: #47

I'm not entirely sure what this section did originally, something with micropython.const clearly. All of the const usages that I found in this repo are on 'private' viariables that aren't listed in the documentation anyhow.

I verified that I can successfully build the docs locally on python 3.12 now. The generated files look the same to me as the ones on the current live docs page.

I also checked the rest of the repos in the bundle and found 1 other similar instance to fix.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 863d6ac into adafruit:main Jan 22, 2025
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 28, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 3.1.14 from 3.1.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#48 from FoamyGuy/fix_docs_build

Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.3.19 from 1.3.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#53 from FoamyGuy/remove_imp_usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#28 from SamantazFox/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#76 from adafruit/fix-print-c-program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs build fails due to usage of imp module
2 participants