Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration patch for newer AHT20's #16

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Calibration patch for newer AHT20's #16

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29c027a
Calibration patch for newer AHT20's
BlitzCityDIY Aug 14, 2023
cc89d00
Updating to use try/except
BlitzCityDIY Aug 14, 2023
e586707
updating to use try/except
BlitzCityDIY Aug 14, 2023
fe1abce
moving try/except
BlitzCityDIY Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions adafruit_ahtx0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,14 @@ def reset(self) -> None:
time.sleep(0.02) # 20ms delay to wake up

def calibrate(self) -> bool:
"""Ask the sensor to self-calibrate. Returns True on success, False otherwise"""
"""Ask the sensor to self-calibrate. May not 'succeed' on newer AHT20s."""
self._buf[0] = AHTX0_CMD_CALIBRATE
self._buf[1] = 0x08
self._buf[2] = 0x00
with self.i2c_device as i2c:
i2c.write(self._buf, start=0, end=3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may fail, so do a try/except pass here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap only the call that can fail, please!

i2c.write(self._buf, start=0, end=3)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ladyada ohh okay, will fix. one question though- in __init__ if calibration returns False then it raises a RuntimeError, should that be changed too to not raise an error? or would the sensor read the SENSOR_CALIBRATED bit with the try/except and not return False?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

image

while self.status & AHTX0_STATUS_BUSY:
time.sleep(0.01)
if not self.status & AHTX0_STATUS_CALIBRATED:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this part in!

return False
return True

@property
Expand Down