Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Comparator functionality #98

Merged
merged 12 commits into from
Aug 6, 2024
Merged

Added Comparator functionality #98

merged 12 commits into from
Aug 6, 2024

Commits on Jul 23, 2024

  1. Added Comparator functionality

    Added controls for the COMP_QUE fields in the Config Register that handle the Comparator output. Also added an example of use.
    RoaCode committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    017fb9f View commit details
    Browse the repository at this point in the history
  2. Improved Comments

    Added comments for new functions
    RoaCode committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c84a39d View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Addressed PR comments

    Added threshold properties, changed to "comparator_queue_length" property name, added "convert to voltage" and "convert to value" functions
    RoaCode committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7d98fde View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Moved threshold writes to setters

    Writing of the threshold registers moved to the setter functions, "threshold" spelled out in variables, improved readability of some comments.
    RoaCode committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0aa1cd7 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Fixed ads1x15 init comment

    Fixed issues in ads1x15 init comment. Removed stray copy/paste and added more info for comparator thresholds.
    RoaCode committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    29ee801 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Corrected Pylint issues

    Disabled instance attributes req for ADS1x15 init function and shortened "possible_comparator_queue_lengths" to "possible_comp_queue_lengths"
    RoaCode committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    a730639 View commit details
    Browse the repository at this point in the history
  2. Correcting pylint issues

    Trying to fix "too many instance attributes" issue
    RoaCode committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f74e4f9 View commit details
    Browse the repository at this point in the history
  3. Moved 2's complement calculation to threshold setters

    Threshold properties changed to 12-bit signed integers and conversion to unsigned 16-bit numbers moved to threshold setter functions.
    RoaCode committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4ba6144 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Moved threshold defaults to subclass

    Adapted functions to use bits properties and moved part specific settings to subclasses
    RoaCode committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    8ddd81c View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Updated comments with threshold register info

    Moved specific comments about threshold registers to subclasses
    RoaCode committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    657b768 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Removed 2s Complement calculations

    Conversion calculations handled with signed integers, removing 2s complement. Removed subclass comparator threshold defaults since both chips have same default values.
    RoaCode committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    f7fd261 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    3e31097 View commit details
    Browse the repository at this point in the history