std::equal is not necessarily constexpr in C++17 (only C++20) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eans that PR #35 broke idna technically.
anonrig
force-pushed
the
dlemire/fix_std_equal_not_constexpr
branch
from
5cdf3f2 to
9c995f5
Compare
anonrig
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::equal is not necessarily constexpr in C++17 (only C++20) which means that PR #35 broke idna technically.
See https://en.cppreference.com/w/cpp/algorithm/equal
This PR keeps std::equal, but removes the constexpr qualifiers on begins_with