Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds a test with a comma. #32

Merged
merged 3 commits into from
Jul 21, 2023
Merged

This adds a test with a comma. #32

merged 3 commits into from
Jul 21, 2023

Conversation

lemire
Copy link
Member

@lemire lemire commented Jul 21, 2023

This PR will fail if we fail to parse "128.0,0.1" without error (a comma is forbidden, but we are lenient).

@lemire
Copy link
Member Author

lemire commented Jul 21, 2023

The failing lint checks are not related to this PR.

@lemire lemire requested a review from anonrig July 21, 2023 15:03
@lemire
Copy link
Member Author

lemire commented Jul 21, 2023

Issued a commit to fix pre-existing linter issue.

@lemire
Copy link
Member Author

lemire commented Jul 21, 2023

Merging.

@lemire lemire merged commit 3a6c7b1 into main Jul 21, 2023
@lemire lemire deleted the adding_comma_test branch July 21, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants