Sea Turtles - Katina Carranza/Theresa Davis #30

kmcarranza · 2022-05-07T04:06:39Z

No description provided.

tgoslee · 2022-05-10T13:14:12Z

app/__init__.py

+    # app.config['SQLALCHEMY_DATABASE_URI'] = 'postgresql+psycopg2://postgres:postgres@localhost:5432/solar_system_development'
+
+    if not test_config:
+        app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False


if you move this line to line 16 then you don't have to put it on line 23

tgoslee · 2022-05-10T13:14:26Z

app/__init__.py

+    # app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False
+    # app.config['SQLALCHEMY_DATABASE_URI'] = 'postgresql+psycopg2://postgres:postgres@localhost:5432/solar_system_development'


you can remove these

tgoslee · 2022-05-10T13:14:47Z

app/models/planet.py

@@ -0,0 +1,8 @@
+from app import db
+
+class Planet(db.Model):


looks good. Would you make these columns nullable?

tgoslee · 2022-05-10T13:15:46Z

app/routes.py

+# class Planet:
+#     def __init__(self, id, name, description, moons):
+#         self.id = id
+#         self.name = name
+#         self.description = description
+#         self.moons = moons
+
+# planets = [
+#     Planet(1, "Mercury", "Mercury is the first planet from the Sun. It is the smallest and the fastest of all planets in our Solar system",0),
+#     Planet(2, "Venus", "Venus is the second planet from the Sun. It spins clockwise on its axis and is the second brightest natural object in the night sky after the Moon", 0),
+#     Planet(3, "Earth", "Third planet from the Sun and our home planet is 4.5 billion years old. The only planet to sustain a liquid surface area", 1),
+#     Planet(4, "Mars", "This planet is named after Mars, the Roman god of war. It's landmass which is similar to Earth, has a reddish-brown color.", 2),
+#     Planet(5, "Jupiter", "Jupiter is the largest of all planets in our Solar system. This gaseous planet is more than twice as large as the other planets combined", 79),
+#     Planet(6, "Saturn", "Saturn is the second largest of the planets and is primarily composed of hydrogen gas. It is known for its over 30 stunning Rings of ice", 82),
+#     Planet(7, "Uranus", "This ice giant is massive with a size four times wider than of Earth. It has 13 known Rings", 27),
+#     Planet(8, "Neptune", "At a distance of 2.8 billion miles from the Sun, this massive planet is four times wider than Earth. It's mainly made up of icy materials- water, methane and ammonia with 7 Rings", 14),
+# ]


you can remove this or move it to another file that has your notes

tgoslee · 2022-05-10T13:16:38Z

app/routes.py

+            planets_response.append({					
+            "id": planet.id,					
+            "name": planet.name,					
+            "description": planet.description,
+            "moons": planet.moons						
+    })						


you can move this to your Planet class and create an instance method that you can reference multiple times.

tgoslee · 2022-05-10T13:17:07Z

app/routes.py

+    return make_response(f"Planet with id {planet.id} was successfully deleted!")
+
+# Helper Function
+def validate_planet(id):


tgoslee · 2022-05-10T13:17:29Z

app/routes.py

+# @planets_bp.route("/<planet_id>", methods=["GET"])	
+# def handle_planet(planet_id):
+#     planet = validate_planet(planet_id)
+#     return {
+#                 "id": planet.id,					
+#                 "name": planet.name,					
+#                 "description": planet.description,
+#                 "moons": planet.moons	
+#             }
+# def validate_planet(planet_id):   
+#     try:
+#         planet_id = int(planet_id)
+#     except:
+#         abort(make_response({"message":f"planet {planet_id} invalid"}, 400))
+
+#     for planet in planets:
+#         if planet.id == planet_id:
+#             return planet
+#     abort(make_response({"message": f"planet {planet_id} not found"}, 404))


you can remove this

tgoslee · 2022-05-10T13:17:56Z

tests/conftest.py

+from app.models.planet import Planet
+
+
+@pytest.fixture


tgoslee · 2022-05-10T13:18:33Z

tests/test_routes.py

+    assert response.status_code == 200
+    assert response_body == []
+
+def test_get_planets(client, two_saved_planets):


this test name could be more descriptive. test_get_planet_by_id since you are looking for planet 1

perugia33 and others added 8 commits April 25, 2022 08:42

first commit

d99ac3d

Merge branch 'ada-c17:main' into main

6de0935

Worked on Wave 1 and Wave 2

985955e

Changes to a dictionary key

07f59d8

added model and migration

74523c9

Completed Wave 3 and 4

0e93148

add query param

c32d8f2

Completed Wave 6 - Tests

48707df

tgoslee reviewed May 10, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sea Turtles - Katina Carranza/Theresa Davis #30

Sea Turtles - Katina Carranza/Theresa Davis #30

kmcarranza commented May 7, 2022

tgoslee May 10, 2022

tgoslee May 10, 2022

tgoslee May 10, 2022

tgoslee May 10, 2022

tgoslee May 10, 2022

tgoslee May 10, 2022

tgoslee May 10, 2022

tgoslee May 10, 2022

tgoslee May 10, 2022

		# app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False
		# app.config['SQLALCHEMY_DATABASE_URI'] = 'postgresql+psycopg2://postgres:postgres@localhost:5432/solar_system_development'

Sea Turtles - Katina Carranza/Theresa Davis #30

Are you sure you want to change the base?

Sea Turtles - Katina Carranza/Theresa Davis #30

Conversation

kmcarranza commented May 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment