refactor: some minor code changes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit applies some minor code changes to cleanup the code.
rickstaa
commented
Feb 12, 2025
rickstaa
commented
Feb 12, 2025
rickstaa
commented
Feb 12, 2025
ad-astra-video
requested changes
Feb 12, 2025
This commit ensures that the transient error messages have the right names.
This commit changes `isTransientError` to `isRetryableError` to make it more in line with the transcoding naming.
rickstaa
force-pushed
the
ricks/ai-video-fix-selection-pr
branch
from
190cd2c to
8812662
Compare
This commit reverts the error changes since this will break backward compatibility with old orchestrators.
rickstaa
force-pushed
the
ricks/ai-video-fix-selection-pr
branch
from
8812662 to
71b0e2e
Compare
This commit makes the `isRetryableError` function case insensitive to prevent unexpected errors from happening in the future. It also adds tests.
|
@ad-astra-video tested again, and made the |
5 tasks
ad-astra-video
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies some minor code changes to clean up the code.