Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added Make Transfer button to mobile. #4516

Closed
wants to merge 2 commits into from

Conversation

tempiz
Copy link

@tempiz tempiz commented Mar 3, 2025

  • Added the Make Transfer button to the mobile client.

This was the only functionality missing in the mobile client for my day to day budgeting. With this change, many users including myself should no longer need to regularly open the desktop client.

Most of this code is reused from the desktop client.

@actual-github-bot actual-github-bot bot changed the title Added Make Transfer button to mobile. [WIP] Added Make Transfer button to mobile. Mar 3, 2025
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit bc29314
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67c5d218e21a180008e8dc97
😎 Deploy Preview https://deploy-preview-4516.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
18 7.08 MB → 7.08 MB (+2.07 kB) +0.03%
Changeset
File Δ Size
src/hooks/useTransactionBatchActions.ts 📈 +1.06 kB (+13.67%) 7.74 kB → 8.8 kB
src/components/mobile/transactions/TransactionList.tsx 📈 +991 B (+5.99%) 16.15 kB → 17.12 kB
src/components/mobile/transactions/TransactionListWithBalances.tsx 📈 +30 B (+0.51%) 5.79 kB → 5.82 kB
src/components/mobile/accounts/AccountTransactions.tsx 📈 +13 B (+0.16%) 7.9 kB → 7.91 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 4.36 MB → 4.36 MB (+2.5 kB) +0.06%
static/js/narrow.js 86.26 kB → 86.27 kB (+13 B) +0.01%

Smaller

Asset File Size % Changed
static/js/wide.js 102.9 kB → 102.45 kB (-457 B) -0.43%

Unchanged

Asset File Size % Changed
static/js/en.js 103.63 kB 0%
static/js/de.js 112.69 kB 0%
static/js/es.js 58.26 kB 0%
static/js/en-GB.js 96.59 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/fr.js 113.61 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/uk.js 111.11 kB 0%
static/js/nl.js 95.56 kB 0%
static/js/pt-BR.js 110.57 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/AppliedFilters.js 10.8 kB 0%
static/js/ReportRouter.js 1.59 MB 0%

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.34 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.34 MB 0%

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 73b27e8
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67c5d227a81a580008f6bab6
😎 Deploy Preview https://deploy-preview-4516.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tempiz
Copy link
Author

tempiz commented Mar 3, 2025

I see another user created a PR around the same time as myself for the same issue. I will close my PR.

@tempiz tempiz closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant