Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐳 Docker images to be published under the actual repo #4483

Merged
merged 2 commits into from
Mar 1, 2025
Merged

🐳 Docker images to be published under the actual repo #4483

merged 2 commits into from
Mar 1, 2025

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Feb 28, 2025 •
edited
Loading

The docker images are currently published to the actual-server repo: https://github.com/actualbudget/actual-server/pkgs/container/actual-server

It has a message saying the repo is readonly so it's not ideal. This PR should publish to this repo as well. We can phase out the old actual-server images in future.

@netlify Netlify
Copy link

netlify bot commented Feb 28, 2025 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit e8ea9e3
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67c23370a635bc00089fc82e
😎 Deploy Preview https://deploy-preview-4483.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MikesGlitch MikesGlitch changed the title 🐳 : Docker images to be published under the actual repo 🐳 Docker images to be published under the actual repo Feb 28, 2025
@MikesGlitch MikesGlitch marked this pull request as ready for review February 28, 2025 22:11
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2025

Walkthrough

The changes update the GitHub Actions workflow files by adding a new Docker image entry to the IMAGES environment variable in both the docker-edge.yml and docker-release.yml workflows. The new entry, ghcr.io/actualbudget/actual, is appended to the existing list of images used during the build, push, and tagging processes. The modification adjusts the image sets processed in each workflow without altering the overall structure or logic of the workflows.

Suggested labels

:sparkles: Merged

Suggested reviewers

  • youngcw
  • jfdoming
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d11fc59 and e8ea9e3.

⛔ Files ignored due to path filters (1)
  • upcoming-release-notes/4483.md is excluded by !**/*.md
📒 Files selected for processing (2)
  • .github/workflows/docker-edge.yml (1 hunks)
  • .github/workflows/docker-release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Visual regression
  • GitHub Check: Functional
  • GitHub Check: build (windows-latest)
🔇 Additional comments (2)
.github/workflows/docker-release.yml (1)

16-16: New Docker Image Entry Added

The new image entry ghcr.io/actualbudget/actual has been successfully added to the IMAGES environment variable. This update aligns with the PR objective to publish Docker images under the actual repository instead of the read-only actual-server repository.

.github/workflows/docker-edge.yml (1)

27-27: Consistent Update to Docker Images List

The addition of ghcr.io/actualbudget/actual in the IMAGES environment variable is consistent with the changes made in the release workflow. This ensures that both the stable and edge workflows now include the image from the actual repository, addressing the read-only issue of the previous setup.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

matt-fidd
matt-fidd approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@matt-fidd matt-fidd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there any additional set up needed or does it just "work"?

@MikesGlitch
Copy link
Contributor Author

LGTM, is there any additional set up needed or does it just "work"?

Should just work. It can go in after the release since we've already made the release PR.

@MikesGlitch MikesGlitch mentioned this pull request Feb 28, 2025
Merged
@jfdoming jfdoming merged commit 103d95b into actualbudget:master Mar 1, 2025
20 checks passed
jfdoming pushed a commit to actualbudget/docs that referenced this pull request Mar 1, 2025
@MikesGlitch
Update github container reference to new repo (#652)
37b570c 
Updating to point to the new github container located here:
https://ghcr.io/actualbudget/actual

This is to accommodate this change:
actualbudget/actual#4483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngcw youngcw youngcw approved these changes

@matt-fidd matt-fidd matt-fidd approved these changes

Assignees
No one assigned
Labels
✨ Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikesGlitch @youngcw @matt-fidd @jfdoming