Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [Mobile] Drag and drop income categories to re-order #4482

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[WIP] [Mobile] Drag and drop income categories to re-order #4482

wants to merge 8 commits into from
+843 −526

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Feb 28, 2025 •
edited
Loading

Drag and drop doesn't seem to work with the Chrome mobile simulator but it works when the demo link is opened in an actual mobile phone.

@actual-github-bot actual-github-bot bot changed the title [Mobile] Drag and drop income categories to re-order [WIP] [Mobile] Drag and drop income categories to re-order Feb 28, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2025 •
edited
Loading

❌ Deploy Preview for actualbudget failed.

Name Link
🔨 Latest commit 65fe93b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67c750a950042d0008bf4fe4

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025 •
edited
Loading

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
18 7.07 MB → 7.34 MB (+277.81 kB) +3.84%
Changeset
File Δ Size
node_modules/@react-aria/dnd/dist/useDroppableCollection.mjs 🆕 +32.72 kB 0 B → 32.72 kB
node_modules/@react-aria/dnd/dist/DragManager.mjs 🆕 +19.1 kB 0 B → 19.1 kB
node_modules/@react-aria/dnd/dist/useDrop.mjs 🆕 +14.53 kB 0 B → 14.53 kB
node_modules/@react-aria/dnd/dist/useDrag.mjs 🆕 +11.88 kB 0 B → 11.88 kB
node_modules/@react-aria/dnd/dist/utils.mjs 🆕 +11.67 kB 0 B → 11.67 kB
node_modules/@react-aria/dnd/dist/ru-RU.mjs 🆕 +9.35 kB 0 B → 9.35 kB
node_modules/@react-aria/dnd/dist/el-GR.mjs 🆕 +9.11 kB 0 B → 9.11 kB
node_modules/@react-aria/dnd/dist/uk-UA.mjs 🆕 +9.09 kB 0 B → 9.09 kB
node_modules/@react-aria/dnd/dist/bg-BG.mjs 🆕 +8.37 kB 0 B → 8.37 kB
src/components/mobile/budget/IncomeCategoryList.tsx 🆕 +7.13 kB 0 B → 7.13 kB
src/components/mobile/budget/IncomeGroup.tsx 🆕 +6.89 kB 0 B → 6.89 kB
node_modules/@react-aria/dnd/dist/ja-JP.mjs 🆕 +6.18 kB 0 B → 6.18 kB
node_modules/@react-aria/dnd/dist/he-IL.mjs 🆕 +6.11 kB 0 B → 6.11 kB
node_modules/@react-aria/dnd/dist/ar-AE.mjs 🆕 +5.8 kB 0 B → 5.8 kB
node_modules/@react-aria/dnd/dist/ListDropTargetDelegate.mjs 🆕 +5.7 kB 0 B → 5.7 kB
node_modules/@react-stately/dnd/dist/useDroppableCollectionState.mjs 🆕 +5.41 kB 0 B → 5.41 kB
node_modules/@react-aria/dnd/dist/useDraggableItem.mjs 🆕 +5.34 kB 0 B → 5.34 kB
node_modules/@react-aria/dnd/dist/ko-KR.mjs 🆕 +5.16 kB 0 B → 5.16 kB
node_modules/@react-aria/dnd/dist/zh-TW.mjs 🆕 +4.21 kB 0 B → 4.21 kB
node_modules/@react-aria/dnd/dist/useDropIndicator.mjs 🆕 +3.78 kB 0 B → 3.78 kB
node_modules/@react-aria/dnd/dist/cs-CZ.mjs 🆕 +3.73 kB 0 B → 3.73 kB
node_modules/@react-aria/dnd/dist/zh-CN.mjs 🆕 +3.7 kB 0 B → 3.7 kB
node_modules/@react-aria/dnd/dist/tr-TR.mjs 🆕 +3.57 kB 0 B → 3.57 kB
node_modules/@react-aria/dnd/dist/pl-PL.mjs 🆕 +3.51 kB 0 B → 3.51 kB
node_modules/@react-aria/dnd/dist/sk-SK.mjs 🆕 +3.5 kB 0 B → 3.5 kB
node_modules/@react-aria/dnd/dist/lt-LT.mjs 🆕 +3.47 kB 0 B → 3.47 kB
node_modules/@react-aria/dnd/dist/hu-HU.mjs 🆕 +3.37 kB 0 B → 3.37 kB
src/components/mobile/budget/BudgetCell.tsx 🆕 +3.35 kB 0 B → 3.35 kB
node_modules/@react-aria/dnd/dist/useAutoScroll.mjs 🆕 +3.34 kB 0 B → 3.34 kB
node_modules/@react-aria/dnd/dist/lv-LV.mjs 🆕 +3.28 kB 0 B → 3.28 kB
node_modules/@react-aria/dnd/dist/ro-RO.mjs 🆕 +3.26 kB 0 B → 3.26 kB
node_modules/@react-aria/dnd/dist/fr-FR.mjs 🆕 +3.25 kB 0 B → 3.25 kB
node_modules/@react-aria/dnd/dist/hr-HR.mjs 🆕 +3.21 kB 0 B → 3.21 kB
node_modules/@react-aria/dnd/dist/sr-SP.mjs 🆕 +3.16 kB 0 B → 3.16 kB
node_modules/@react-aria/dnd/dist/de-DE.mjs 🆕 +3.16 kB 0 B → 3.16 kB
node_modules/@react-aria/dnd/dist/sl-SI.mjs 🆕 +3.12 kB 0 B → 3.12 kB
node_modules/@react-stately/dnd/dist/useDraggableCollectionState.mjs 🆕 +3.07 kB 0 B → 3.07 kB
node_modules/@react-aria/dnd/dist/fi-FI.mjs 🆕 +3.04 kB 0 B → 3.04 kB
node_modules/@react-aria/dnd/dist/es-ES.mjs 🆕 +3.01 kB 0 B → 3.01 kB
node_modules/@react-aria/dnd/dist/et-EE.mjs 🆕 +3 kB 0 B → 3 kB
node_modules/react-aria-components/dist/useDragAndDrop.mjs 🆕 +2.87 kB 0 B → 2.87 kB
node_modules/@react-aria/dnd/dist/da-DK.mjs 🆕 +2.86 kB 0 B → 2.86 kB
node_modules/@react-aria/dnd/dist/sv-SE.mjs 🆕 +2.85 kB 0 B → 2.85 kB
node_modules/@react-aria/dnd/dist/it-IT.mjs 🆕 +2.84 kB 0 B → 2.84 kB
node_modules/@react-aria/dnd/dist/pt-PT.mjs 🆕 +2.84 kB 0 B → 2.84 kB
node_modules/@react-aria/dnd/dist/pt-BR.mjs 🆕 +2.79 kB 0 B → 2.79 kB
node_modules/@react-aria/dnd/dist/nb-NO.mjs 🆕 +2.75 kB 0 B → 2.75 kB
node_modules/@react-aria/dnd/dist/nl-NL.mjs 🆕 +2.74 kB 0 B → 2.74 kB
node_modules/@react-aria/dnd/dist/useDroppableItem.mjs 🆕 +2.69 kB 0 B → 2.69 kB
node_modules/@react-aria/dnd/dist/en-US.mjs 🆕 +2.53 kB 0 B → 2.53 kB
node_modules/@react-aria/dnd/dist/constants.mjs 🆕 +2.24 kB 0 B → 2.24 kB
node_modules/@react-aria/dnd/dist/useVirtualDrop.mjs 🆕 +1.88 kB 0 B → 1.88 kB
node_modules/@react-aria/dnd/dist/DragPreview.mjs 🆕 +1.86 kB 0 B → 1.86 kB
node_modules/@react-aria/dnd/dist/intlStrings.mjs 🆕 +1.43 kB 0 B → 1.43 kB
node_modules/@react-aria/dnd/dist/useDraggableCollection.mjs 🆕 +1.07 kB 0 B → 1.07 kB
node_modules/@react-aria/interactions/dist/useFocusVisible.mjs 📈 +774 B (+6.50%) 11.63 kB → 12.39 kB
locale/fr.json 📈 +1.76 kB (+1.99%) 88.87 kB → 90.64 kB
locale/es.json 📉 -6 B (-0.01%) 60.58 kB → 60.58 kB
src/components/mobile/budget/BudgetTable.jsx 📉 -14.53 kB (-26.34%) 55.16 kB → 40.63 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow.js 86.23 kB → 361.53 kB (+275.3 kB) +319.25%
static/js/fr.js 88.87 kB → 90.64 kB (+1.76 kB) +1.99%
static/js/index.js 4.35 MB → 4.35 MB (+774 B) +0.02%

Smaller

Asset File Size % Changed
static/js/es.js 60.58 kB → 60.58 kB (-6 B) -0.01%

Unchanged

Asset File Size % Changed
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/pt-BR.js 112.83 kB 0%
static/js/AppliedFilters.js 10.8 kB 0%
static/js/nl.js 97.78 kB 0%
static/js/uk.js 111.11 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/wide.js 102.9 kB 0%
static/js/de.js 114.35 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/en.js 103.18 kB 0%
static/js/en-GB.js 98.67 kB 0%
static/js/ReportRouter.js 1.59 MB 0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025 •
edited
Loading

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.34 MB → 1.34 MB (+5 B) +0.00%
Changeset
File Δ Size
packages/loot-core/src/server/db/sort.ts 📈 +7 B (+0.37%) 1.83 kB → 1.83 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.34 MB → 1.34 MB (+5 B) +0.00%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@joel-jeremy joel-jeremy mentioned this pull request Mar 1, 2025
Open
@joel-jeremy joel-jeremy force-pushed the mobile-income-category-dnd branch from 769c514 to 65fe93b Compare March 4, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🚧 WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joel-jeremy