Final PR for react-aria-components Modal migration #3413
Merged
+1,513
−2,083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
joel-jeremy
changed the title
MatissJanis
reviewed
Sep 10, 2024
| import { Paragraph } from '../common/Paragraph'; | ||
| import { View } from '../common/View'; | ||
|
|
||
| export function GoCardlessLink() { | ||
| window.close(); |
There was a problem hiding this comment.
I think we want to keep this line. Otherwise the window won't automatically close after linking.
The flow is:
- initialise the linking
- that opens the linking in popover
- the user follows bank login there
- finally the popover redirects back to actual
- we close the popover (this line)
- the root window is visible again and linking is success
There was a problem hiding this comment.
Nice catch! Thanks for pointing that out. Updated :)
| @@ -67,144 +72,122 @@ export function ManagementApp({ isLoading }) { | |||
| // redux so that it persists across renders. This will show the | |||
| // loading spinner on first run, but never again since we'll have | |||
| // a cached list of files and can show them | |||
| if (!managerHasInitialized) { | |||
There was a problem hiding this comment.
I think we want to get rid of the comment above too.
MatissJanis
approved these changes
Sep 11, 2024
a-gradina
pushed a commit
to a-gradina/actual
that referenced
this pull request
Sep 15, 2024
* Final PR for react-aria-components Modal migration * Complete manager modals migration * Release notes * fix lint * Apps full height * Fix lint error * VRT * Centralize providers * Feedback
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please bear with me on this large PR. Changes made:
Modalcomponent and renamedModal2toModalModalscomponents instead of 2 separateButton2naming