Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad account sort order in demo #2279

Merged
merged 8 commits into from
Jan 26, 2024

Conversation

youngcw
Copy link
Member

@youngcw youngcw commented Jan 24, 2024

something about the batchmessages call was breaking. I set this up the same as how categories and groups are getting created.

fixes #2264

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 512dcd9
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65b16409f583ea0008fa92c7
😎 Deploy Preview https://deploy-preview-2279.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.98 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/narrow.js 81.84 kB 0%
static/js/wide.js 239.61 kB 0%
static/js/ReportRouter.js 1.84 MB 0%
static/js/index.js 2.64 MB 0%

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB → 1.18 MB (-8 B) -0.00%
Changeset
File Δ Size
packages/loot-core/src/mocks/budget.ts 📉 -35 B (-0.12%) 28.52 kB → 28.48 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.18 MB → 1.18 MB (-8 B) -0.00%

Unchanged

No assets were unchanged

@youngcw youngcw requested a review from joel-jeremy January 24, 2024 17:31
joel-jeremy
joel-jeremy previously approved these changes Jan 24, 2024
Copy link
Contributor

@joel-jeremy joel-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm just wondering whether categories have the same issue since they're also batched.

@youngcw
Copy link
Member Author

youngcw commented Jan 24, 2024

LGTM! I'm just wondering whether categories have the same issue since they're also batched.

the categories seem good. Ill ping you when the tests are fixed

@youngcw youngcw requested a review from joel-jeremy January 24, 2024 19:27
@joel-jeremy joel-jeremy added this to the v24.2.0 milestone Jan 26, 2024
@youngcw youngcw merged commit 43ebe9e into master Jan 26, 2024
19 checks passed
@youngcw youngcw deleted the youngcw/fix-demo-accounts-sort-order branch January 26, 2024 16:12
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 26, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* fix bad sort order in demo

* note

* add async back

* fix tests

* fix2

* fix3

* update vrt

* fix image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Import does not properly set the account sort_order database columns
2 participants