🏷️ making some files comply with strict TS #2247
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| requiredFields('payee', payee, ['name'], update); | ||
| return payee; | ||
| }, | ||
| }; | ||
|
|
||
| export const transactionModel = { |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged No assets were unchanged |
There was a problem hiding this comment.
@MatissJanis these changes look good, but it needs another update from master and some fixes as the requiredFields change has an error with one of it's callers there.
trafico-bot
bot
added
⚠️ Changes requested
trafico-bot
bot
added
🔍 Ready for Review
and removed
⚠️ Changes requested
| requiredFields('reports', report, ['conditions'], update); | ||
| requiredFields('reports', report, ['conditionsOp'], update); |
There was a problem hiding this comment.
cc @carkom the conditions field doesn't exist on the CustomReportEntity type. LMK if you're ok with the patch I did here
trafico-bot
bot
added
✨ Merged
No description provided.