Custom Reports - add schema #2246
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
| ); | ||
| } | ||
|
|
||
| const flag = true; |
There was a problem hiding this comment.
Tried to explain it in commnets in line 23.
"useReports" is meant to pull an array of all reports in the db table...except there's no db table yet. This is the work-around I implemented so that the code doesn't create fatal errors. It's basically returning an empty array but all this code will be used for querying the db for saved reports.
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
trafico-bot
bot
added
✨ Merged
* Add schema work * notes * merge fixes * add to handlers * notes update * Update packages/loot-core/src/server/reports/app.ts Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> * review changes * type updates --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
This is all backend work to saving reports from the Custom Report feature.