Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert FiltersMenu to Typescript (part 1) #2231

Merged
merged 10 commits into from
Feb 2, 2024

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Jan 14, 2024

Split out all the elements into separate files - working to get rid of mega-files in the code base. Updated all those files to Typescript.

Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 832811c
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65b3a83e4e2a040008fb08a9
😎 Deploy Preview https://deploy-preview-2231.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 14, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.98 MB → 4.98 MB (+67 B) +0.00%
Changeset
File Δ Size
src/components/filters/FilterExpression.tsx 🆕 +2.49 kB 0 B → 2.49 kB
src/components/filters/AppliedFilters.tsx 🆕 +767 B 0 B → 767 B
src/components/filters/updateFilterReducer.ts 🆕 +719 B 0 B → 719 B
src/components/filters/subfieldToOptions.ts 🆕 +661 B 0 B → 661 B
src/components/filters/OpButton.tsx 🆕 +513 B 0 B → 513 B
src/components/filters/subfieldFromFilter.ts 🆕 +454 B 0 B → 454 B
src/components/filters/SavedFilters.jsx 📈 +49 B (+0.50%) 9.54 kB → 9.58 kB
src/components/filters/FiltersMenu.jsx 📉 -5.52 kB (-31.33%) 17.61 kB → 12.1 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
static/js/AppliedFilters.js 0 B → 28.99 kB (+28.99 kB) -

Removed

Asset File Size % Changed
static/js/FiltersMenu.js 28.92 kB → 0 B (-28.92 kB) -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 81.84 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/wide.js 239.61 kB 0%
static/js/ReportRouter.js 1.84 MB 0%
static/js/index.js 2.64 MB 0%

Copy link
Contributor

github-actions bot commented Jan 14, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.18 MB 0%

@carkom carkom changed the title Convert FiltersMenu to Typescript [WIP] Convert FiltersMenu to Typescript Jan 17, 2024
@carkom carkom force-pushed the convertFiltersMenu branch from dbd7b33 to 6bb0376 Compare January 19, 2024 21:21
@carkom carkom changed the title [WIP] Convert FiltersMenu to Typescript Convert FiltersMenu to Typescript Jan 24, 2024
@carkom carkom changed the title Convert FiltersMenu to Typescript Convert FiltersMenu to Typescript (part 1) Jan 24, 2024
@twk3
Copy link
Contributor

twk3 commented Jan 25, 2024

@carkom what do you think about using a utils.ts to hold subfieldFromFilter, subfieldToOptions and updateFilterReducer?

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review labels Jan 25, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Jan 26, 2024
@carkom
Copy link
Contributor Author

carkom commented Jan 27, 2024

@carkom what do you think about using a utils.ts to hold subfieldFromFilter, subfieldToOptions and updateFilterReducer?

I think we are focused on avoiding combined files in this project.

@carkom carkom requested a review from twk3 January 27, 2024 16:45
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new changes look good. Thanks!

@carkom carkom merged commit 5914469 into actualbudget:master Feb 2, 2024
19 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Feb 2, 2024
@carkom carkom deleted the convertFiltersMenu branch February 2, 2024 20:10
@trafico-bot trafico-bot bot removed the ✅ Approved label Feb 2, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* migration work

* notes

* typecheck

* typecheck fixes

* fixes

* merge fixes

* typecheck updates

* review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants