-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert FiltersMenu to Typescript (part 1) #2231
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
dbd7b33
to
6bb0376
Compare
@carkom what do you think about using a |
packages/desktop-client/src/components/filters/subfieldFromFilter.ts
Outdated
Show resolved
Hide resolved
packages/desktop-client/src/components/filters/subfieldToOptions.ts
Outdated
Show resolved
Hide resolved
I think we are focused on avoiding combined files in this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new changes look good. Thanks!
* migration work * notes * typecheck * typecheck fixes * fixes * merge fixes * typecheck updates * review fixes
Split out all the elements into separate files - working to get rid of mega-files in the code base. Updated all those files to Typescript.