Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (typescript) fixing strictNullChecks=true issues #2228

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

MatissJanis
Copy link
Member

Part 2 of: #2212

Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 715af09
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65a6de4c6e20cf0008fbccf5
😎 Deploy Preview https://deploy-preview-2228.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 14, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.08 MB → 5.08 MB (-1.72 kB) -0.03%
Changeset
File Δ Size
src/hooks/useSelected.tsx 📈 +124 B (+1.64%) 7.4 kB → 7.52 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/months.ts 📈 +26 B (+0.59%) 4.29 kB → 4.32 kB
src/components/transactions/SelectedTransactions.jsx 📉 -51 B (-1.04%) 4.79 kB → 4.74 kB
src/components/Modals.tsx 📉 -145 B (-1.71%) 8.27 kB → 8.13 kB
src/components/transactions/SimpleTransactionsTable.jsx 📉 -182 B (-2.70%) 6.59 kB → 6.41 kB
src/components/schedules/ScheduleDetails.jsx 📉 -811 B (-2.87%) 27.57 kB → 26.78 kB
src/components/schedules/ScheduleLink.tsx 📉 -721 B (-24.55%) 2.87 kB → 2.16 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 2.64 MB → 2.63 MB (-1.67 kB) -0.06%
static/js/wide.js 239.04 kB → 238.99 kB (-51 B) -0.02%

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/narrow.js 82.17 kB 0%
static/js/BalanceTooltip.js 6.07 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/ReportRouter.js 1.95 MB 0%

Copy link
Contributor

github-actions bot commented Jan 14, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.23 MB → 1.23 MB (-7 B) -0.00%
Changeset
File Δ Size
packages/loot-core/src/shared/months.ts 📈 +26 B (+0.28%) 9.02 kB → 9.04 kB
packages/loot-core/src/shared/async.ts 📉 -47 B (-3.47%) 1.32 kB → 1.28 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.23 MB (-7 B) -0.00%

Unchanged

No assets were unchanged

@MatissJanis MatissJanis force-pushed the matiss/ts-strict-null-checks-2 branch from 4f2d118 to 3a1e9cd Compare January 14, 2024 17:42
@MatissJanis MatissJanis marked this pull request as ready for review January 14, 2024 17:55
@MatissJanis MatissJanis merged commit ff11399 into master Jan 18, 2024
17 checks passed
@MatissJanis MatissJanis deleted the matiss/ts-strict-null-checks-2 branch January 18, 2024 08:23
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 18, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* ♻️ (typescript) fixing strictNullChecks=true issues

* Patch test-helpers

* Strict patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants