Skip to content

Commit

Permalink
♻️ do not check outdated version for preview builds (#4183)
Browse files Browse the repository at this point in the history
  • Loading branch information
MatissJanis authored Jan 18, 2025
1 parent 87c2604 commit 7cb5350
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
6 changes: 5 additions & 1 deletion packages/desktop-client/src/browser-preload.browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ const backendWorkerUrl = new URL('./browser-server.js', import.meta.url);
// everything else.

const IS_DEV = process.env.NODE_ENV === 'development';
const ACTUAL_VERSION = Platform.isPlaywright ? '99.9.9' : packageJson.version;
const ACTUAL_VERSION = Platform.isPlaywright
? '99.9.9'
: process.env.REACT_APP_REVIEW_ID
? '.preview'
: packageJson.version;

// *** Start the backend ***
let worker;
Expand Down
2 changes: 1 addition & 1 deletion packages/desktop-client/src/util/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function cmpSemanticVersion(
}

export async function getLatestVersion(): Promise<string | 'unknown'> {
if (Platform.isPlaywright) {
if (Platform.isPlaywright || process.env.REACT_APP_REVIEW_ID) {
return Promise.resolve('v99.9.9');
}

Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/4183.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [MatissJanis]
---

Do not check if active version is outdated for preview builds.

0 comments on commit 7cb5350

Please sign in to comment.