🐛 [Goals]: Fix inconsistent schedule amounts (#4265)

* remove the balance check

* fix inconsistent schedule amounts

* note, cleanup

* update error

* lint;test

packages/loot-core/src/server/budget/categoryTemplate.ts

@@ -126,10 +126,7 @@ export class CategoryTemplate {
           break;
         }
         case 'schedule': {
-          const budgeted = await getSheetValue(
-            monthUtils.sheetForMonth(this.month),
-            `leftover-${this.category.id}`,
-          );
+          const budgeted = this.fromLastMonth + toBudget;
           const ret = await goalsSchedule(
             scheduleFlag,
             t,

packages/loot-core/src/server/budget/template-notes.test.ts

@@ -224,7 +224,7 @@ describe('checkTemplates', () => {
       expected: {
         sticky: true,
         message: 'There were errors interpreting some templates:',
-        pre: 'cat1: Schedule “Non-existent Schedule” does not exist',
+        pre: 'Category 1: Schedule “Non-existent Schedule” does not exist',
       },
     },
   ];

packages/loot-core/src/server/budget/template-notes.ts

@@ -40,15 +40,15 @@ export async function checkTemplates(): Promise<Notification> {
   const scheduleNames = schedules.map(({ name }) => name);
   const errors: string[] = [];
 
-  categoryWithTemplates.forEach(({ id, name, templates }) => {
+  categoryWithTemplates.forEach(({ name, templates }) => {
     templates.forEach(template => {
       if (template.type === 'error') {
         errors.push(`${name}: ${template.line}`);
       } else if (
         template.type === 'schedule' &&
         !scheduleNames.includes(template.name)
       ) {
-        errors.push(`${id}: Schedule “${template.name}” does not exist`);
+        errors.push(`${name}: Schedule “${template.name}” does not exist`);
       }
     });
   });

upcoming-release-notes/4265.md

@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [youngcw]
+---
+
+Fix schedule templates sometimes budgeting wrong amounts