Skip to content
This repository has been archived by the owner on Feb 10, 2025. It is now read-only.

Corner case transaction for GoCardLess adapater (ING Romania) #535

Merged
merged 7 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/app-gocardless/banks/ing-ingbrobu.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,17 @@ export default {
if (transaction.transactionId === 'NOTPROVIDED') {
if (booked) {
transaction.transactionId = transaction.internalTransactionId;

//Some corner case transactions have a special field called `proprietaryBankTransactionCode`, this need to be copied to `remittanceInformationUnstructured`
if (
transaction.proprietaryBankTransactionCode &&
!transaction.remittanceInformationUnstructured
) {
transaction.remittanceInformationUnstructured =
transaction.proprietaryBankTransactionCode;
}
if (
transaction.remittanceInformationUnstructured &&
transaction.remittanceInformationUnstructured
.toLowerCase()
.includes('card no:')
Expand All @@ -32,7 +42,16 @@ export default {
}
} else {
transaction.transactionId = null;

if (
transaction.proprietaryBankTransactionCode &&
!transaction.remittanceInformationUnstructured
) {
transaction.remittanceInformationUnstructured =
transaction.proprietaryBankTransactionCode;
}
if (
transaction.remittanceInformationUnstructured &&
transaction.remittanceInformationUnstructured
.toLowerCase()
.includes('card no:')
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/535.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [spideraxal]
---

Add corner case transaction for ING Bank Romania
Loading