Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sqlx_todo CI checks #415

Merged
merged 6 commits into from
Mar 3, 2021
Merged

Fix sqlx_todo CI checks #415

merged 6 commits into from
Mar 3, 2021

Conversation

danitrod
Copy link
Contributor

@danitrod danitrod commented Mar 2, 2021 •
edited
Loading

Switches the example to use sqlite and adds sqlite3 to the CI.

Closes #412

@robjtede
Copy link
Member

robjtede commented Mar 2, 2021 •
edited
Loading

since this adds sqlx back to the workspace, i'd ask that you make clippy happy while we're here :)

otherwise, this looks great

@danitrod
Copy link
Contributor Author

danitrod commented Mar 2, 2021

My bad, forgot about that. All good now

@robjtede robjtede requested review from a team March 2, 2021 22:28
JohnTitor
JohnTitor approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have a mention to postgresql on README (Line 3), it should be replaced as well. Otherwise LGTM 👍

@danitrod
Copy link
Contributor Author

danitrod commented Mar 3, 2021

nice catch, good to go now :)

@JohnTitor
Copy link
Member

We've encountered bheisler/TinyTemplate#17, let's just ignore it.
Thanks for fixing it!

@JohnTitor JohnTitor merged commit 7487a81 into actix:master Mar 3, 2021
@danitrod danitrod deleted the fix-sqlx-checks branch March 3, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include sqlx in ci checks
3 participants
@danitrod @robjtede @JohnTitor