-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HeyLight icon #1245
Add HeyLight icon #1245
Conversation
Hi @Lydia-shan-git, would it be possible to get a review on this please? Keen to get this available for our merchants by the 6/11/24 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, did you already pass it through SVGO to reduce file size?
Hi @Lydia-shan-git, yes already passed through. Followed the guidance :) |
Hi @Lydia-shan-git, thank you for approving. Do you know when this will me merged/deployed? |
Hi @heidi-luke-saheed , we are aiming to merge these icons on Nov 13th |
Great, thanks for the update @dannye0231 😃 |
Hi @dannye0231 @Lydia-shan-git, hope you're having a good week! Are we still on track for this to be deployed today? 😃 |
Hi @dannye0231 @Lydia-shan-git, was wondering if you had an updated deploy date for this icon? We would like to get this out ASAP for our customers as the original target date was 1st November. If there's anything I can do to help please let me know |
Hi @heidi-luke-saheed , we ran into issues last week when attempting to merge these changes as certain repos are now locked down due to Black Friday approaching. We're now aiming for early December to re-attempt a merge once the locks have been lifted on our core repos. |
Hi @dannye0231, thank you for the update |
Thank you for the merge @dannye0231, excited to inform our customers! 😀 |
Why are you adding this icons?
I'm adding/updating this icon(s) because I work for HeyLight (formerly HeidiPay) and want it for Shopify
Help us identify yourself
Link to the brand guidelines: HeyLight branding guidelines
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?
01/11/24